Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Repository field to package.json #578

Merged
merged 2 commits into from
Feb 11, 2014
Merged

Add Repository field to package.json #578

merged 2 commits into from
Feb 11, 2014

Conversation

topherbullock
Copy link
Contributor

Seeing "npm WARN package.json http-proxy@1.0.2 No repository field." makes me anxious 😧
This PR adds a repo field to the package.json, for others who feel the same.

Seeing "npm WARN package.json http-proxy@1.0.2 No repository field." makes me anxious and its such an easy action to add a repo field to the package.json.
@jcrugzz
Copy link
Contributor

jcrugzz commented Feb 7, 2014

@xtreme-topher-bullock thanks for the contribution! Would you mind changing it to look like...

"repository": {
  "type": "git",
  "url": "git@github.com:nodejitsu/node-http-proxy.git"
}

After that I'll merge it right in :). It makes it display correctly on npmjs.org

@topherbullock
Copy link
Contributor Author

Updated! Also fixed the formatting to match the style of the rest of the file. 😄

@jcrugzz
Copy link
Contributor

jcrugzz commented Feb 11, 2014

@xtreme-topher-bullock thanks :)

jcrugzz added a commit that referenced this pull request Feb 11, 2014
Add Repository field to package.json
@jcrugzz jcrugzz merged commit 1067054 into http-party:master Feb 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants