Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Angular] Add tests for MetricsModalThreadsComponent #23712

Merged

Conversation

qmonmert
Copy link
Contributor

@qmonmert qmonmert commented Oct 2, 2023

Add tests and improve coverage: https://sonarcloud.io/component_measures?id=jhipster-sample-application&metric=coverage&selected=jhipster-sample-application%3Asrc%2Fmain%2Fwebapp%2Fapp%2Fadmin%2Fmetrics%2Fblocks%2Fmetrics-modal-threads%2Fmetrics-modal-threads.component.ts

Before
image

After
image


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@qmonmert qmonmert force-pushed the testMetricsModalThreadsComponent branch from b71bd9c to 34f33c4 Compare October 2, 2023 17:55
@DanielFran DanielFran merged commit b26ac31 into jhipster:main Oct 2, 2023
36 checks passed
@deepu105 deepu105 added this to the 8.0.0-rc.1 milestone Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants