Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Java and Node versions supported #23975

Merged
merged 4 commits into from
Oct 28, 2023
Merged

Add Java and Node versions supported #23975

merged 4 commits into from
Oct 28, 2023

Conversation

mraible
Copy link
Contributor

@mraible mraible commented Oct 24, 2023

Fixes #23933.

mraible
mraible commented Oct 24, 2023
View reviewed changes
README.md Outdated
| Java | Node | Status |
|------|------|--- ----|
| 21 | 20 | ✅ |
| 17 | 18 | ✅ |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mshima It'd be awesome if the status icon could be dynamic based on the matrix results.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think it’s possibe.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this table accurate or does it need to be updated?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this table accurate or does it need to be updated?

I don't know how are we going to add the node/java matrix yet.
From the table I would think that we are test node20/java21 together and node18/java17 together.
Node 20 should be ok to generate applications, but test is broken.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should create the matrix workflows at daily builds.
We can add a workflow for each combination, badges will be available.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

@DanielFran DanielFran merged commit 739c75a into main Oct 28, 2023
62 checks passed
@DanielFran DanielFran deleted the supported-versions branch October 28, 2023 11:46
@deepu105 deepu105 added this to the 8.0.0 milestone Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshima mshima mshima left review comments

@DanielFran DanielFran DanielFran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Add supported Java and Node versions
4 participants
@mraible @mshima @DanielFran @deepu105