Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test defaults #24232

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Improve test defaults #24232

merged 2 commits into from
Nov 15, 2023

Conversation

mshima
Copy link
Member

@mshima mshima commented Nov 15, 2023

  • add a default creationTimestamp
  • pass useVersionPlaceholders and fakeKeytool using test utilities defaults instead of env variable at mocha config bootstrap.
    They will be applied at blueprints too.
  • deprecate applicationWithEntities option. It's mainly used by tests now and withJHipsterConfig can be used instead.

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@DanielFran DanielFran merged commit da6b283 into jhipster:main Nov 15, 2023
66 of 102 checks passed
@mshima mshima deleted the skip_ci-tests branch November 16, 2023 21:28
@deepu105 deepu105 added this to the 8.1.0 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants