refactor: add German translation keys for cache metrics #24994
Conversation
The German translation keys for Metrics is missing nine keys. Add the translation keys. Translations provided by Markus Bernhardt. An additional key missing in the global.json is also provided.
|
🙏 @mraible for such quick resolution! |
| "puts": "Anzahl geschriebener Objekte", | ||
| "removals": "Anzahl gelöschter Objekte", | ||
| "evictions": "Anzahl entfernter Objekte", | ||
| "hitPercent": "Trefferwahrscheinlichkeit %", |
There was a problem hiding this comment.
As a native german speaker I think this is not totally correct. I think the metric describes the hit and miss ratio and not the hit or miss probability. So maybe "(Cache)-Treffer %" and "(Cache)-Fehler %".
There was a problem hiding this comment.
A native German speaker in Munich did the translations; I ran the PR submission.
The missing keys came up in a Gitter conversation. I'm not so invested in the debate of the translation as the missing keys. With the keys in place, a discussion of the translation is fair game @atomfrede .
There was a problem hiding this comment.
Yes the actual translation is not that important and easy to change. Thanks for the pr!
There was a problem hiding this comment.
Yes, you are right. I think it should be "(Cache)-Treffer %" or "Trefferquote %".
There was a problem hiding this comment.
Both seem fine. Cache-Treffer is close to to the english one, while Trefferquote would be more common german wording. I would go with trefferquote maybe.
The German translation keys for Metrics is missing nine keys. Add the translation keys. Translations provided by Markus Bernhardt.
An additional key missing in the global.json is also provided.
See #24993
Fixes #24993
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.