Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loggers should be 'private static final' #26532

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

qmonmert
Copy link
Contributor

Same as #26531 without renaming


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@qmonmert qmonmert marked this pull request as ready for review June 24, 2024 20:59
@mshima
Copy link
Member

mshima commented Jun 24, 2024

Does this PR fixes the issue?

@qmonmert
Copy link
Contributor Author

@mshima which issue?

@mshima
Copy link
Member

mshima commented Jun 24, 2024

#26531 (comment), log needs to be upper case to be fixed?

Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not merging since I am considering we are in code freeze due to the release.

@qmonmert
Copy link
Contributor Author

@mshima this PR is a simplified PR of #26531 because we must decide if we rename log into LOGGER

@mshima
Copy link
Member

mshima commented Jun 24, 2024

@mshima this PR is a simplified PR of #26531 because we must decide if we rename log into LOGGER

So the issue still exists with lower case log. Am I correct?

LOG should be accepted too.

@mraible mraible merged commit 924b8d8 into jhipster:main Jun 24, 2024
52 checks passed
@mraible mraible added this to the 8.6.0 milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants