Skip to content

Commit

Permalink
All: Set min version for synchronising to 3.0.0
Browse files Browse the repository at this point in the history
  • Loading branch information
@laurent22
laurent22 committed Jun 29, 2024
1 parent 17e1eec commit e4b8976
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/lib/services/synchronizer/syncInfoUtils.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export interface SyncInfoValuePublicPrivateKeyPair {
//
// `appMinVersion_` should really just be a constant but for testing purposes it can be changed
// using `setAppMinVersion()`
let appMinVersion_ = '0.0.0';
let appMinVersion_ = '3.0.0';

export const setAppMinVersion = (v: string) => {
appMinVersion_ = v;
Expand Down

6 comments on commit e4b8976

@nokoa77
Copy link

@nokoa77 nokoa77 commented on e4b8976 Jul 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Does it mean that client version >3.0 will only sync with server version >3.0 ?
Thanks
Bruno

@laurent22
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that clients v3 will only sync with clients v3. But all these clients have been released now, so that should not be an issue.

@ggruen
Copy link

@ggruen ggruen commented on e4b8976 Jul 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, to clarify, if I'm traveling and have devices at home running v2.14, and I upgrade my Android phone and my laptop to v3, what would happen? Sounds like the phone and laptop will stop syncing until I get home and update those clients?

@laurent22
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it's the devices with version 2.14 that will stop syncing. They'll need to be upgraded to v3 too

@femanuel
Copy link

@femanuel femanuel commented on e4b8976 Jul 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
I am using the (unofficial) Flatpak client v.2.14.22 on my Raspberry Pi 5 (ARM64) with a Nextcloud installation as the server. The client now tells me to update to version 3.x.x in order to sync. Android and Windows clients are already updated. Unfortunately, there is no Flatpak v3.x.x available (yet), AppImage is not working on RPi5.
Will there be a ARM64 client as well?

What would you recommend me?
Thank you.

@laurent22
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all these clients you would need to ask the maintainers of these packages. We put in a lot of efforts to ensure that we release the version 3 for all supported operating system at the same time to avoid this issue. But anything else outside of this, we can't control. I'd expect they'll release a new version soon though.

Please sign in to comment.