Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading from last version 2.x Joplin to latest 3.x facing folder expanding slowness issue. #10674

Closed
toomding opened this issue Jul 3, 2024 · 5 comments
Labels
bug It's a bug desktop All desktop platforms high High priority issues mobile All mobile platforms

Comments

@toomding
Copy link

toomding commented Jul 3, 2024

Operating system

Windows

Joplin version

3.0.12

Desktop version info

Joplin 3.0.12 (prod, win32)

Client ID: dbbb0ba7b0014de28c9c5f6cd297ea00
Sync Version: 3
Profile Version: 47
Keychain Supported: Yes

Revision: a64d6e3

Backup: 1.4.1

Current behaviour

Since today received Joplin 3.x version upgrading reminder. I upgrade my 2 pc and 1 mac Joplin to the latest version.

All machines face slowness in expanding folders. I get a huge Joplin collections contain 23K notes and combined into multiple folders and layered and stacked folder and sub-folders.

So i used expand folder a lot. just after i upgrade to the latest it became very slow.

it can take 15s and even longer and it will then trigger the no response warning and let me decide if ignore or quite it.
image

If i choose to ignore and wait a longer it will eventually ok but take many times.

After restarted to safe mode, it is still slow, and it happened on 2 pc and 1 mac just after i upgrade to 3.0.12 version.

Nothing changed and just the version upgrading.

I used the backend server 2.14.2 and it is doing good.

The note is rendered well and perfect still. it just the slowness when expand folders.

My 2 pc and 1 mac is super-fast and no workload in background and i didn't see the cpu jump if i expand the folder.

Expected behaviour

Expected it will be quick like <2s but now it takes 20s to be expanded and unable to do collections and order.

Logs

No response

@toomding toomding added the bug It's a bug label Jul 3, 2024
@toomding
Copy link
Author

toomding commented Jul 3, 2024

Hi Expert,

I reproduced the issue and expand a folder it takes > 20s.
image

and grab the Performance logs.

Trace-20240703T094346.json

@laurent22 laurent22 added desktop All desktop platforms high High priority issues labels Jul 3, 2024
personalizedrefrigerator added a commit to personalizedrefrigerator/joplin that referenced this issue Jul 3, 2024
…ssion with many nested notebooks

Fixes a regression that seems to be introduced by
f19b1c5. This seems related to
`folderHasChildren_` and related methods going from O(n) to O(n^2) (new
`folders.find(f => f.id === parent_id)` logic to find original parent
items).

This commit fixes the issue by caching parent items in a `Map`.
@personalizedrefrigerator personalizedrefrigerator added the mobile All mobile platforms label Jul 3, 2024
@toomding
Copy link
Author

toomding commented Jul 3, 2024

Thank you so much personalizeddrefrigerator, much appreciated for your swift work and quick insight on what the issue cause is going on. Please accept my deep thanks to you. 🤗

Wondering when this fix will hit the next release or what would be the next release number version of Joplin?

@personalizedrefrigerator
Copy link
Collaborator

Wondering when this fix will hit the next release or what would be the next release number version of Joplin?

The fix has been merged into the release-3.0 branch. Hopefully it will be available in a few days!

@personalizedrefrigerator
Copy link
Collaborator

personalizedrefrigerator commented Jul 6, 2024

A user has confirmed on the forum that this issue also seems to affect mobile.

@personalizedrefrigerator
Copy link
Collaborator

personalizedrefrigerator commented Jul 6, 2024

The fix should be available in v3.0.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug desktop All desktop platforms high High priority issues mobile All mobile platforms
Projects
None yet
Development

No branches or pull requests

3 participants