-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Focus is lost when the hyperlink modal is cancelled #9970
Comments
Hello everyone, I've come across this issue and I would like to take a shot at resolving it. I'll keep you all posted on my progress. |
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions. |
Re: bot reply, still an issue in 2.14.20. |
… is cancelled When closing the hyperlink prompt dialog, either by clicking cancel or just by pressing escape, the prompt function returns a promise that is never resolved or rejected, hence not executing the following code which would give back focus to the editor. This behaviour happens because the smalltalk library checks for a cancel option. If this option is false or undefined (which was always the case), the promise that is returned is never cancelled/rejected. What I did was set this option to true so that the promise can be rejected and therefore continue the flow of execution. Signed-off-by: Fabio Neto <fabiogvdneto@tecnico.ulisboa.pt>
Operating system
Linux
Joplin version
2.13.15
Desktop version info
Joplin 2.13.15 (prod, linux)
Client ID: 59929b147fa5436cbc8a24035555730a
Sync Version: 3
Profile Version: 44
Keychain Supported: No
Current behaviour
<Ctrl-K>
to open the Insert Hyperlink modal. The field receives focus, as expected.<Enter>
or click OK, everything works fine. However, if I hit<Esc>
or click Cancel, the pane loses focus. It seems Joplin is still in focus, since pressing<Alt>
focuses the File menu, but I need to click back into the pane to start typing again. (I can also<Shift-Tab>
3 times or<Tab>
4 times to focus the Markdown pane again, in case that helps narrow down what's focuses after cancelling the modal. I've tried arrow keys, etc., but can't see where focus is going.)Expected behaviour
Upon cancelling the hyperlink modal, I would expect to return to where the cursor was previously.
Logs
No response
The text was updated successfully, but these errors were encountered: