Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fixes #10672: External editing: Fix notes often not updated when saved from Vim #10780

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Jul 23, 2024

Summary

This pull request fixes #10672 by removing an outdated workaround for a resolved upstream issue.

Testing plan

  1. Set gvim as the external editor.
  2. Open a note.
  3. Click the "open in external editor" button.
  4. Make a change.
  5. Save with :w.
  6. Verify that the change is visible in Joplin.
  7. Repeat steps 4-6 for 2-3 more small changes.
  8. Set the external editor to gnome-text-editor (/usr/bin/gnome-text-editor for me).
  9. Open two notes using the "toggle external editor" button.
  10. Make changes to both notes from gnome-text-editor and save.
  11. Verify that both changes are shown in Joplin.

This has been tested successfully on Ubuntu 24.04.

@laurent22 laurent22 merged commit 0935b6f into laurent22:dev Jul 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#10186 still a problem (Data lost during long external editing session)
2 participants