Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desktop: Fixes #10895: Fix alt+up/alt+down fails to re-order multiple lines #10899

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Desktop: Fixes #10895: Fix alt+up/alt+down fails to re-order multiple lines #10899

merged 1 commit into from
Aug 22, 2024

Conversation

personalizedrefrigerator
Copy link
Collaborator

Summary

This pull request fixes #10895 by replacing the custom swapLine editor command with the built-in CodeMirror moveLineUp and moveLineDown commands.

Testing plan

  1. Start the desktop app.
  2. Select multiple lines.
  3. Press alt-up. Verify that all selected lines are moved up.
  4. Press alt-down. Verify that all selected lines are moved down.

@laurent22 laurent22 merged commit 6a0dd4e into laurent22:dev Aug 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression of reordering selected lines between 3.0.8 and 3.1.1
2 participants
@personalizedrefrigerator @laurent22