protobuf: remove gogoproto #5342
Open
+70,437
−75,191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/dockerfile
area/llb
area/hack
jsternberg
force-pushed
the
gogoproto-remove
branch
from
e57b510
to
665e7c3
Compare
jsternberg
force-pushed
the
gogoproto-remove
branch
13 times, most recently
from
bf597a3
to
49259d7
Compare
jsternberg
force-pushed
the
gogoproto-remove
branch
4 times, most recently
from
9299af9
to
55e7f50
Compare
Remove gogoproto in favor of the standard protobuf compiler. This removes any nonstandard extensions that were part of gogoproto such as the custom types. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
vtproto is an extra protobuf compiler that generates special methods suffixed with `VT` that create typed and unrolled marshal and unmarshal functions similar to gogo that can be used for performance sensitive code. These extensions are optional for code to use but buildkit uses them. A codec is also included to utilize vtproto for grpc code. If the package `github.com/moby/buildkit/util/encoding/proto` is imported then vtproto will be used if it exists and otherwise it will use the standard marshaling and unmarshaling methods. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
jsternberg
force-pushed
the
gogoproto-remove
branch
from
55e7f50
to
63ab902
Compare
jsternberg
commented
Sep 19, 2024
| gopkg.in/yaml.v3 v3.0.1 // indirect | ||
| kernel.org/pub/linux/libs/security/libcap/psx v1.2.70 // indirect | ||
| ) | ||
|
|
||
| replace github.com/tonistiigi/fsutil => github.com/jsternberg/fsutil v0.0.0-20240918154141-5822a7180d7a |
There was a problem hiding this comment.
TODO: change this before merging
|
This is ready for review now. This should replace #4422. I've separated the vtproto stuff into its own commit but the dependency seems to work and alleviates or removes the concern that this will affect the performance. |
|
Not sure why but I see freebsd job fails: https://github.com/moby/buildkit/actions/runs/10948325927/job/30399181953?pr=5342#step:10:12 And same happens on fsutil repo for tonistiigi/fsutil#206: https://github.com/tonistiigi/fsutil/actions/runs/10930826082/job/30344567135?pr=206 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove gogoproto in favor of the standard protobuf compiler and use vtproto to supplement the standard protobuf compiler.
This removes any nonstandard extensions that were part of gogoproto such as the custom types.
vtproto is an extra protobuf compiler that generates special methods suffixed with
VTthat create typed and unrolled marshal and unmarshal functions similar to gogo that can be used for performance sensitive code. These extensions are optional for code to use but buildkit uses them.A codec is also included to utilize vtproto for grpc code. If the package
github.com/moby/buildkit/util/encoding/protois imported then vtproto will be used if it exists and otherwise it will use the standard marshaling and unmarshaling methods.