Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better overflow and wrapping in Status area #7850

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

charlesh88
Copy link
Contributor

@charlesh88 charlesh88 commented Sep 19, 2024

Closes #6655

Describe your changes:

  • Added new button that toggles single and multi-line displays of Indicators.
  • Button highlights when Indicators are overflowing in single-line mode.
  • Indicators as icon-only or icon-and-label now toggle independently from single and multi-line displays.

TODOs:

  • Updated tests, visual tests?

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

- Added `headCanWrap` stored property, and toggle button.
- CSS mods, cleanup.
- New glyphs for `icon-multiline` and `icon-singleline`.
- Refinements to button labels and titles for clarity.
- Add code and CSS for toggling single/multiline display of indicators.
- Add code to detect overflow state of indicators.
- WIP, but is working!
- TODOs:
  - Make sure this is a good way to do things.
  - Cleanup code.
  - Tests.
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 16 lines in your changes missing coverage. Please review.

Project coverage is 58.76%. Comparing base (de122b9) to head (e494bee).

Files with missing lines Patch % Lines
src/ui/layout/status-bar/StatusIndicators.vue 21.42% 11 Missing ⚠️
src/ui/layout/AppLayout.vue 37.50% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7850      +/-   ##
==========================================
- Coverage   59.18%   58.76%   -0.42%     
==========================================
  Files         675      675              
  Lines       27284    27306      +22     
  Branches     2671     2675       +4     
==========================================
- Hits        16148    16047     -101     
- Misses      11089    11210     +121     
- Partials       47       49       +2     
Flag Coverage Δ
e2e-ci 61.77% <ø> (-0.01%) ⬇️
e2e-full 23.51% <ø> (-18.43%) ⬇️
unit 51.18% <27.27%> (-0.15%) ⬇️
Files with missing lines Coverage Δ
src/ui/layout/AppLayout.vue 29.82% <37.50%> (+1.25%) ⬆️
src/ui/layout/status-bar/StatusIndicators.vue 42.85% <21.42%> (-42.86%) ⬇️

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de122b9...e494bee. Read the comment docs.

- Fixed CSS classing on collapse/expand button.
- New method added for storing head props in local storage.
- TODOs:
  - Make sure using Update hook is performant.
  - Tests.
…AppLayout.vue component.

- Code cleanup, console.log removals.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Status bar needs a better collapse strategy
1 participant