Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safekeeper: remove unused partial_backup_enabled option #8547

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

dotdister
Copy link
Contributor

@dotdister dotdister commented Jul 30, 2024

Problem

There is an unused safekeeper option partial_backup_enabled.

partial_backup_enabled was implemented in #6530, but this option was always turned into enabled in #8022.

If you intended to keep this option for a specific reason, I will close this PR.

Summary of changes

I removed an unused safekeeper option partial_backup_enabled.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@dotdister dotdister requested a review from a team as a code owner July 30, 2024 07:26
@dotdister dotdister requested a review from arssher July 30, 2024 07:26
@arpad-m arpad-m added the approved-for-ci-run Changes are safe to trigger CI for the PR label Jul 30, 2024
@github-actions github-actions bot removed the approved-for-ci-run Changes are safe to trigger CI for the PR label Jul 30, 2024
@vipvap vipvap mentioned this pull request Jul 30, 2024
@arpad-m
Copy link
Member

arpad-m commented Jul 30, 2024

Thanks for the PR @dotdister ! It seems that we still set the flag in our internal deployments, even though as you correctly point out it is redundant. I have initiated the process of removing it from our deployments (internal link https://github.com/neondatabase/aws/pull/1660 ).

Copy link

3138 tests run: 3017 passed, 0 failed, 121 skipped (full report)


Code coverage* (full report)

  • functions: 32.8% (7024 of 21387 functions)
  • lines: 50.0% (55895 of 111712 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
36e49ab at 2024-07-30T12:16:07.145Z :recycle:

@arpad-m
Copy link
Member

arpad-m commented Jul 30, 2024

The internal changes were applied and will be rolled out at the next week's deploy. To make sure the option is really gone from config files, I think we should merge this next week.

@dotdister
Copy link
Contributor Author

Thank you for quick review and response for internal use !

The internal changes were applied and will be rolled out at the next week's deploy. To make sure the option is really gone from config files, I think we should merge this next week.

Yes, I understand. I will wait for the next week's deploy.

@arpad-m arpad-m merged commit 0f3dac2 into neondatabase:main Aug 5, 2024
74 checks passed
jcsp pushed a commit that referenced this pull request Aug 12, 2024
## Problem
There is an unused safekeeper option `partial_backup_enabled`.

`partial_backup_enabled` was implemented in #6530, but this option was
always turned into enabled in #8022.

If you intended to keep this option for a specific reason, I will close
this PR.

## Summary of changes
I removed an unused safekeeper option `partial_backup_enabled`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants