Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI(regress-tests): run less regression tests #8561

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Jul 31, 2024

Problem

We run regression tests on release & debug builds for each of the three supported Postgres versions (6 in total).
With upcoming ARM support and Postgres 17, the number of jobs will jump to 16, which is a lot.

See internal discussion here: https://neondb.slack.com/archives/C033A2WE6BZ/p1722365908404329

Summary of changes

  • Run regress-tests job in debug builds only with the latest Postgres version
  • Do not do debug build on release branches

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@bayandin bayandin requested review from a team, knizhnik and skyzh and removed request for a team July 31, 2024 09:44
@bayandin bayandin changed the title CI(regress-tests): run debug builds only with the latest Postgres version CI(regress-tests): run less regression tests Jul 31, 2024
Copy link

github-actions bot commented Jul 31, 2024

2100 tests run: 2033 passed, 0 failed, 67 skipped (full report)


Code coverage* (full report)

  • functions: 32.5% (7022 of 21597 functions)
  • lines: 49.9% (55873 of 111995 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
d2ce1c1 at 2024-07-31T13:07:46.696Z :recycle:

@bayandin bayandin force-pushed the bayandin/run-less-regress-tests branch from 544240b to b206788 Compare July 31, 2024 10:57
@bayandin bayandin force-pushed the bayandin/run-less-regress-tests branch from b206788 to d2ce1c1 Compare July 31, 2024 12:12
@bayandin bayandin merged commit d21246c into main Jul 31, 2024
66 checks passed
@bayandin bayandin deleted the bayandin/run-less-regress-tests branch July 31, 2024 14:10
arpad-m pushed a commit that referenced this pull request Aug 5, 2024
## Problem
We run regression tests on `release` & `debug` builds for each of the
three supported Postgres versions (6 in total).
With upcoming ARM support and Postgres 17, the number of jobs will jump
to 16, which is a lot.

See the internal discussion here:
https://neondb.slack.com/archives/C033A2WE6BZ/p1722365908404329

## Summary of changes
- Run `regress-tests` job in debug builds only with the latest Postgres
version
- Do not do `debug` builds on release branches
bayandin added a commit that referenced this pull request Aug 30, 2024
## Problem

`promote-compatibility-data` job got broken and slightly outdated after 
- #8552 -- we don't upload
artifacts for ARM64
- #8561 -- we don't prepare
`debug` artifacts in the release branch anymore

## Summary of changes
- Promote artifacts from release PRs to the latest version (but do it
from `release` branch)
- Upload artifacts for both X64 and ARM64
@bayandin bayandin mentioned this pull request Sep 16, 2024
5 tasks
bayandin added a commit that referenced this pull request Sep 17, 2024
## Problem

We've got 2 non-blocking failures on the release pipeline:
- `promote-compatibility-data` job got skipped _presumably_ because one
of the dependencies of `deploy` job (`push-to-acr-dev`) got skipped
(#8940)
- `coverage-report` job fails because we don't build debug artifacts in
the release branch (#8561)

## Summary of changes
- Always run `push-to-acr-dev` / `push-to-acr-prod` jobs, but add
`skip_if` parameter to the reusable workflow, which can skip the job
internally, without skipping externally
- Do not run `coverage-report` on release branches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants