Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: make TLS and WS handling optional #8752

Merged
merged 4 commits into from
Aug 20, 2024
Merged

Conversation

conradludgate
Copy link
Contributor

Problem

#8736 is getting too big. splitting off some simple changes here

Summary of changes

Local proxy wont always be using tls, so make it optional. Local proxy wont be using ws for now, so make it optional. Remove a dead config var.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@conradludgate conradludgate requested a review from a team as a code owner August 19, 2024 10:26
@conradludgate conradludgate enabled auto-merge (squash) August 19, 2024 10:26
Copy link

github-actions bot commented Aug 19, 2024

2172 tests run: 2108 passed, 0 failed, 64 skipped (full report)


Flaky tests (4)

Postgres 16

  • test_combocid: debug
  • test_forward_compatibility: debug
  • test_layer_bloating: debug
  • test_lfc_resize: debug

Code coverage* (full report)

  • functions: 32.4% (7236 of 22307 functions)
  • lines: 50.4% (58431 of 115933 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
96898f4 at 2024-08-20T13:05:40.521Z :recycle:

@conradludgate conradludgate enabled auto-merge (squash) August 19, 2024 14:40
proxy/src/serverless/sql_over_http.rs Outdated Show resolved Hide resolved
proxy/src/config.rs Outdated Show resolved Hide resolved
@conradludgate conradludgate changed the title proxy: small changes proxy: make TLS and WS handling optional Aug 20, 2024
@conradludgate conradludgate merged commit 0170611 into main Aug 20, 2024
63 checks passed
@conradludgate conradludgate deleted the proxy-maybe-tls-http branch August 20, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants