Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safekeeper: check for non-consecutive writes in safekeeper.rs #8781

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

arssher
Copy link
Contributor

@arssher arssher commented Aug 21, 2024

wal_storage.rs already checks this, but since this is a quite legit scenario check it at safekeeper.rs (consensus level) as well.

ref #8212

This is a take 2; previous PR #8640 had been reverted because interplay with another change broke test_last_log_term_switch.

@arssher arssher requested a review from a team as a code owner August 21, 2024 09:59
Copy link

github-actions bot commented Aug 21, 2024

3808 tests run: 3702 passed, 0 failed, 106 skipped (full report)


Flaky tests (4)

Postgres 16

Postgres 15

  • test_delete_timeline_exercise_crash_safety_failpoints[Check.RETRY_WITHOUT_RESTART-timeline-delete-before-schedule]: release-arm64

Postgres 14

Code coverage* (full report)

  • functions: 32.5% (7423 of 22847 functions)
  • lines: 50.6% (60114 of 118755 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
3427fd1 at 2024-09-03T15:02:07.914Z :recycle:

Copy link
Contributor

@problame problame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new unit test to assert we hit precisely the added error in the presumed scenario would be great.

safekeeper/src/safekeeper.rs Show resolved Hide resolved
wal_storage.rs already checks this, but since this is a quite legit scenario
check it at safekeeper.rs (consensus level) as well.

ref #8212

This is a take 2; previous PR #8640 had been reverted because interplay
with another change broke test_last_log_term_switch.
@arssher arssher force-pushed the sk-check-non-consecutive-writes-2 branch from b835fa5 to 3427fd1 Compare September 3, 2024 14:00
@arssher arssher merged commit c7187be into main Sep 3, 2024
67 checks passed
@arssher arssher deleted the sk-check-non-consecutive-writes-2 branch September 3, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants