Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compute): Introduce new compute_subscriptions_count metric #8796

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

ololobus
Copy link
Member

Problem

We need some metric to sneak peek into how many people use inbound logical replication (Neon is subscriber).

Summary of changes

This commit adds a new metric compute_subscriptions_count, which is number of subscriptions grouped by enabled/disabled state.

Resolves: neondatabase/cloud#16146

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

We need some metric to sneak peek into how many people use inbound
logical replication (Neon is subscriber).

This commit adds a new metric `compute_subscriptions_count`, which is
number of subscriptions grouped by enabled/disabled state.

Resolves: neondatabase/cloud#16146
Copy link
Member

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this against all Postgres versions? Note that we don't have regression tests for sqlexporter unfortunately #8569

@ololobus
Copy link
Member Author

I tested in PG14-16, yes, but only in 16 I had at least 1 subscription. I still assume that if the schema didn't change, it's OK

Copy link

github-actions bot commented Aug 21, 2024

3827 tests run: 3721 passed, 0 failed, 106 skipped (full report)


Flaky tests (5)

Postgres 15

  • test_scrubber_physical_gc[None]: release
  • test_scrubber_scan_pageserver_metadata[None]: release
  • test_scrubber_physical_gc_ancestors_split: release
  • test_creating_tenant_conf_after_attach: release
  • test_tenant_delete_smoke: release

Code coverage* (full report)

  • functions: 32.4% (7245 of 22346 functions)
  • lines: 50.4% (58497 of 116048 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
01f7e30 at 2024-08-22T14:56:06.649Z :recycle:

@ololobus ololobus merged commit d48229f into main Aug 26, 2024
70 checks passed
@ololobus ololobus deleted the alexk/lr-adoption-metrics branch August 26, 2024 12:34
lubennikovaav pushed a commit that referenced this pull request Aug 28, 2024
## Problem

We need some metric to sneak peek into how many people use inbound
logical replication (Neon is a subscriber).

## Summary of changes

This commit adds a new metric `compute_subscriptions_count`, which is
number of subscriptions grouped by enabled/disabled state.

Resolves: neondatabase/cloud#16146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants