Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline archival test #8824

Merged
merged 8 commits into from
Aug 26, 2024
Merged

Timeline archival test #8824

merged 8 commits into from
Aug 26, 2024

Conversation

arpad-m
Copy link
Member

@arpad-m arpad-m commented Aug 24, 2024

This PR:

  • Implements the rule that archived timelines require all of their children to be archived as well, as specified in the RFC. There is no fancy locking mechanism though, so the precondition can still be broken. As a TODO for later, we still allow unarchiving timelines with archived parents.
  • Adds an is_archived flag to TimelineInfo
  • Adds timeline_archival_config to PageserverHttpClient
  • Adds a new test_timeline_archive test, loosely based on test_timeline_delete

Part of #8088

Copy link

github-actions bot commented Aug 24, 2024

3773 tests run: 3667 passed, 0 failed, 106 skipped (full report)


Code coverage* (full report)

  • functions: 32.2% (7258 of 22572 functions)
  • lines: 50.3% (58795 of 116990 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
e25b59d at 2024-08-24T14:59:21.580Z :recycle:

@arpad-m arpad-m merged commit 2dd53e7 into main Aug 26, 2024
67 checks passed
@arpad-m arpad-m deleted the arpad/timeline_archival_test branch August 26, 2024 15:30
arpad-m added a commit that referenced this pull request Aug 29, 2024
If a timeline unarchival request comes in, give an error if the parent
timeline is archived. This prevents us from the situation of having an
archived timeline with children that are not archived.

Follow up of #8824

Part of #8088

---------

Co-authored-by: Joonas Koivunen <joonas@neon.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants