bench: flush before shutting down #8844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koivunej
added
the
run-benchmarks
3868 tests run: 3752 passed, 0 failed, 116 skipped (full report)Flaky tests (2)Postgres 16
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
18c463a at 2024-08-27T20:12:24.808Z :recycle: |
while driving by: - remove the extra tenant - remove the extra timelines implement this by turning the pg_compare to a yielding fixture.
bayandin
force-pushed
the
joonas/graceful_stop_in_bench
branch
from
e7750aa
to
bd5cb2a
Compare
VladLazar
approved these changes
Aug 28, 2024
bayandin
approved these changes
Aug 28, 2024
|
|
||
| # Start pg | ||
| self._pg = self.env.endpoints.create_start(branch_name, "main", self.tenant) | ||
| self._pg = self.env.endpoints.create_start("main", "main", self.tenant) |
There was a problem hiding this comment.
Optional, just to make it look less confusing:
Suggested change
| self._pg = self.env.endpoints.create_start("main", "main", self.tenant) | |
| self._pg = self.env.endpoints.create_start(branch_name="main", endpoint_id="main", self.tenant) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while driving by:
implement this by turning the pg_compare to a yielding fixture.
evidence: https://neon-github-public-dev.s3.amazonaws.com/reports/main/10571779162/index.html#suites/9681106e61a1222669b9d22ab136d07b/3bbe9f007b3ffae1/