Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pageserver): is_archived should be optional #8902

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Sep 3, 2024

Problem

Summary of changes

Set the field to optional, otherwise there will be decode errors when newer version of the storage controller receives the JSON from older version of the pageservers.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh requested a review from jcsp September 3, 2024 16:19
@skyzh skyzh requested a review from a team as a code owner September 3, 2024 16:19
@jcsp jcsp requested a review from bayandin September 3, 2024 16:35
Copy link
Member

@bayandin bayandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing for such cases will be added in https://github.com/neondatabase/cloud/issues/14722

Copy link

github-actions bot commented Sep 3, 2024

3815 tests run: 3709 passed, 0 failed, 106 skipped (full report)


Code coverage* (full report)

  • functions: 32.5% (7424 of 22870 functions)
  • lines: 50.6% (60118 of 118869 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
aca8897 at 2024-09-03T17:16:13.565Z :recycle:

@skyzh skyzh merged commit 3d9001d into main Sep 3, 2024
69 checks passed
@skyzh skyzh deleted the skyzh/is-archive branch September 3, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants