Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage-scrubber): wrong trial condition #8905

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Sep 3, 2024

Problem

ref #8872

Summary of changes

We saw stuck storage scrubber in staging caused by infinite retries. I believe here we should use min instead of max to avoid getting minutes or hours of retry backoff.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh requested review from jcsp, arpad-m and yliang412 and removed request for jcsp September 3, 2024 20:00
Copy link

github-actions bot commented Sep 3, 2024

3841 tests run: 3734 passed, 1 failed, 106 skipped (full report)


Failures on Postgres 16

# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_sharding_split_failures[release-pg16-failure15]"

Code coverage* (full report)

  • functions: 32.5% (7428 of 22880 functions)
  • lines: 50.6% (60161 of 118977 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
ef57afa at 2024-09-03T21:48:06.816Z :recycle:

@skyzh skyzh enabled auto-merge (squash) September 3, 2024 21:28
@skyzh skyzh merged commit ecfa3d9 into main Sep 3, 2024
69 checks passed
@skyzh skyzh deleted the skyzh/fix-scrubber-retry branch September 3, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants