Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: don't let one timeout eat entire retry budget #8924

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

cloneable
Copy link
Contributor

@cloneable cloneable commented Sep 5, 2024

This reduces the per-request timeout to 10sec while keeping the total retry duration at 1min.

Relates: neondatabase/cloud#15944

Problem

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

This reduces the per-request timeout to 10sec while keeping
the total retry duration at 1min.
@cloneable cloneable requested a review from a team as a code owner September 5, 2024 09:57
@github-actions github-actions bot added the external A PR or Issue is created by an external user label Sep 5, 2024
@bayandin bayandin removed the external A PR or Issue is created by an external user label Sep 5, 2024
Copy link
Contributor

@stradig stradig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link

github-actions bot commented Sep 5, 2024

3829 tests run: 3719 passed, 0 failed, 110 skipped (full report)


Flaky tests (1)

Postgres 15

Code coverage* (full report)

  • functions: 32.3% (7429 of 23006 functions)
  • lines: 50.5% (60174 of 119170 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
2935d00 at 2024-09-05T10:51:42.045Z :recycle:

@cloneable cloneable merged commit 6dfbf49 into main Sep 5, 2024
69 checks passed
@cloneable cloneable deleted the cloneable/proxy-fix-reporting-retry branch September 5, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants