Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libs: tweak PageserverUtilization::is_overloaded #8946

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented Sep 6, 2024

Problem

Having run in production for a while, we see that nodes are generally safely oversubscribed by about a factor of 2.

Summary of changes

Tweak the is_overloaded method to check for utililzation over 200% rather than over 100%

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jcsp jcsp requested a review from VladLazar September 6, 2024 13:41
@jcsp jcsp requested a review from a team as a code owner September 6, 2024 13:41
@jcsp jcsp added a/tech_debt Area: related to tech debt c/storage/controller Component: Storage Controller labels Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

3836 tests run: 3722 passed, 0 failed, 114 skipped (full report)


Flaky tests (5)

Postgres 16

Postgres 15

Postgres 14

Code coverage* (full report)

  • functions: 31.9% (7343 of 23027 functions)
  • lines: 50.0% (59485 of 118906 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
41bb866 at 2024-09-06T15:15:27.385Z :recycle:

@jcsp jcsp changed the title libs: teak PageserverUtilization::is_overloaded libs: tweak PageserverUtilization::is_overloaded Sep 8, 2024
@jcsp jcsp merged commit cb06054 into main Sep 11, 2024
75 checks passed
@jcsp jcsp deleted the jcsp/tweak-utilization-scheduling branch September 11, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt c/storage/controller Component: Storage Controller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants