Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add CodeQL security scanning #844

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

smorimoto
Copy link
Contributor

As the title says.

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • contribution guidelines followed
    here

@codecov-io
Copy link

codecov-io commented Jan 16, 2021

Codecov Report

Merging #844 (222bcdb) into main (e1716d6) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #844   +/-   ##
=======================================
  Coverage   96.12%   96.12%           
=======================================
  Files          31       31           
  Lines         929      930    +1     
=======================================
+ Hits          893      894    +1     
  Misses         36       36           
Impacted Files Coverage Δ
lib/grab-project.js 92.00% <0.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1716d6...222bcdb. Read the comment docs.

@targos
Copy link
Member

targos commented Mar 5, 2021

It is not clear to me what CodeQL scanning can do for CITGM.

@smorimoto
Copy link
Contributor Author

@targos Well, it used to be known as LGTM, but now it's part of GitHub and continues to improve in open place.

Signed-off-by: Sora Morimoto <sora@morimoto.io>
@MylesBorins
Copy link
Contributor

Hey all, I made a boo boo on main and had to force push. I've rebased this branch and force pushed to make sure that you don't have to do extra work because of my mistake

@smorimoto
Copy link
Contributor Author

There is no problem at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants