Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: normalise sourcemap option to boolean #2344

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Conversation

danielroe
Copy link
Contributor

@danielroe danielroe commented Aug 24, 2023

πŸ”— Linked issue

nuxt/nuxt#22787

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This respects the new inline value for sourcemaps. This isn't an urgent fix as v3.7 shouldn't break anything for users but will break this module's build/CI when Nuxt 3.7 lands.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from kazupon August 24, 2023 20:22
@danielroe danielroe self-assigned this Aug 24, 2023
Copy link
Collaborator

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ❀️

@kazupon kazupon merged commit cd9c3de into next Aug 25, 2023
9 checks passed
@kazupon kazupon deleted the fix/sourcemap-hidden branch August 25, 2023 01:48
DarthGigi pushed a commit to DarthGigi/i18n that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants