Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot resolve localePath correctly #2534

Merged
merged 5 commits into from
Nov 5, 2023
Merged

fix: cannot resolve localePath correctly #2534

merged 5 commits into from
Nov 5, 2023

Conversation

kazupon
Copy link
Collaborator

@kazupon kazupon commented Nov 4, 2023

πŸ”— Linked issue

resolve #2523
resolve #2525

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This issues is fixed via vue-i18n-routing

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@kazupon kazupon changed the title fix: bump deps fix: cannot resolve localePath correctly Nov 4, 2023
@kazupon
Copy link
Collaborator Author

kazupon commented Nov 4, 2023

@BobbieGoede
Can you add tests for cases #2523 and #2525 for regression? πŸ™

@kazupon
Copy link
Collaborator Author

kazupon commented Nov 4, 2023

You can push fix/bump-deps branch.

@BobbieGoede
Copy link
Collaborator

@BobbieGoede Can you add tests for cases #2523 and #2525 for regression? πŸ™

Added the regression tests.

For #2523 I had to guess the intended usage as there was no minimal reproduction.. The example given in the issue description would not have worked, so I made the assumption that the following changes would have been the intended usage.

const { localePath } = useLocalePath();
-const url = localePath('path/as a test')`
+const url = localePath(`/path/${encodeURI('as a test')}`)

Let me know if this should be different!

@kazupon
Copy link
Collaborator Author

kazupon commented Nov 5, 2023

@BobbieGoede
Thanks for your testing!

@kazupon kazupon merged commit 4a511e8 into main Nov 5, 2023
7 checks passed
@kazupon kazupon deleted the fix/bump-deps branch November 5, 2023 01:22
DarthGigi pushed a commit to DarthGigi/i18n that referenced this pull request Apr 16, 2024
* fix: bump deps

* chore: more bump deps

* fix: revert vue-i18n and unplugin-vue-i18n version

* test: add regression test for nuxt-modules#2525

* test: add regression test for nuxt-modules#2523

---------

Co-authored-by: Bobbie Goede <bobbiegoede@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hash in NuxtLink don't work with LocalePath LocalePath double encoding URLs, causing 404s
2 participants