fixbug(zlx): random_collect compatible to episode collector #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… random_collect_fn to replace entries' corresponding code
PaParaZz1
approved these changes
Jan 18, 2022
PaParaZz1
added
bug
Codecov Report
@@ Coverage Diff @@
## main #190 +/- ##
==========================================
+ Coverage 83.81% 84.05% +0.23%
==========================================
Files 437 439 +2
Lines 33427 34025 +598
==========================================
+ Hits 28018 28600 +582
- Misses 5409 5425 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
11 tasks
puyuan1996
added a commit
to puyuan1996/DI-engine
that referenced
this pull request
Apr 18, 2022
* fixbug(zlx): make random_collect compatible to episode collector; use random_collect_fn to replace entries' corresponding code * fixbug(zlx): Fix comments by nyz; Add function random_collect's unittest * polish(pu): polish serial entry for td3_vae and reward_model_ngu * format(zlx): flake8 style Co-authored-by: zlx-sensetime <zhaoliangxuan@sensetime.com> Co-authored-by: puyuan1996 <2402552459@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix bug of inital random collect, make it compatible to episode collector.
Use a
random_collect_fnto replace all corresponding codes in entries.Related Issue
#184
TODO
@puyuan1996
td3_vae(different from other entries)
reward_model_ngu(TODO on
collector_kwargs)Check List