Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(nyz): add stochastic dueling network #234

Merged
merged 2 commits into from
Mar 17, 2022
Merged

feature(nyz): add stochastic dueling network #234

merged 2 commits into from
Mar 17, 2022

Conversation

PaParaZz1
Copy link
Member

Description

Stochastic Dueling Network proposed in ACER

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@PaParaZz1 PaParaZz1 added the algo Add new algorithm or improve old one label Mar 8, 2022
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #234 (0312390) into main (5dc47cc) will decrease coverage by 0.09%.
The diff coverage is 96.00%.

@@            Coverage Diff             @@
##             main     #234      +/-   ##
==========================================
- Coverage   86.38%   86.29%   -0.10%     
==========================================
  Files         461      464       +3     
  Lines       35167    36351    +1184     
==========================================
+ Hits        30379    31369     +990     
- Misses       4788     4982     +194     
Flag Coverage Δ
unittests 86.29% <96.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/model/common/head.py 99.03% <94.11%> (-0.97%) ⬇️
ding/model/common/tests/test_head.py 100.00% <100.00%> (ø)
ding/model/template/q_learning.py 86.51% <0.00%> (-9.73%) ⬇️
ding/model/template/atoc.py 94.21% <0.00%> (-1.06%) ⬇️
ding/envs/env_manager/subprocess_env_manager.py 79.91% <0.00%> (-0.22%) ⬇️
ding/policy/__init__.py 100.00% <0.00%> (ø)
ding/torch_utils/network/__init__.py 100.00% <0.00%> (ø)
ding/torch_utils/network/gtrxl.py 97.20% <0.00%> (ø)
ding/torch_utils/network/tests/test_gtrxl.py 100.00% <0.00%> (ø)
ding/policy/r2d2_gtrxl.py 17.81% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dc47cc...0312390. Read the comment docs.

Copy link
Collaborator

@zjowowen zjowowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this pull request is a very good implementation for Stochastic Dueling Networks (SDNs) in ACER algorithm with normal distribution policies.

@PaParaZz1 PaParaZz1 merged commit c02d048 into main Mar 17, 2022
@PaParaZz1 PaParaZz1 deleted the dev-sdn branch March 17, 2022 04:02
puyuan1996 pushed a commit to puyuan1996/DI-engine that referenced this pull request Apr 18, 2022
* feature(nyz): add stochastic dueling network

* polish(nyz): polish sdn and add unittest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algo Add new algorithm or improve old one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants