Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(xjx): add k8s parser #243

Merged
merged 3 commits into from
Mar 24, 2022
Merged

feature(xjx): add k8s parser #243

merged 3 commits into from
Mar 24, 2022

Conversation

sailxjx
Copy link
Member

@sailxjx sailxjx commented Mar 23, 2022

Description

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #243 (9b076f5) into main (0b02a02) will increase coverage by 0.24%.
The diff coverage is 79.33%.

@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
+ Coverage   85.52%   85.76%   +0.24%     
==========================================
  Files         466      468       +2     
  Lines       35738    36383     +645     
==========================================
+ Hits        30566    31205     +639     
- Misses       5172     5178       +6     
Flag Coverage Δ
unittests 85.76% <79.33%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/entry/cli_parsers/tests/test_slurm_parser.py 100.00% <ø> (ø)
ding/entry/cli_ditask.py 34.52% <8.69%> (-0.62%) ⬇️
ding/entry/cli_parsers/k8s_parser.py 94.44% <94.44%> (ø)
ding/entry/cli_parsers/__init__.py 100.00% <100.00%> (ø)
ding/entry/cli_parsers/tests/test_k8s_parser.py 100.00% <100.00%> (ø)
ding/interaction/tests/test_utils/stream.py 75.00% <0.00%> (-2.78%) ⬇️
ding/worker/collector/marine_parallel_collector.py 89.86% <0.00%> (-1.39%) ⬇️
ding/utils/autolog/value.py 100.00% <0.00%> (ø)
ding/utils/loader/string.py 100.00% <0.00%> (ø)
ding/interaction/base/app.py 100.00% <0.00%> (ø)
... and 164 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b02a02...9b076f5. Read the comment docs.

Copy link
Collaborator

@zjowowen zjowowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not found any fault in the code so far. I think this kubernetes parser for command line would perform well as the similar slurm parser does, once the correct configuration being provided.

@sailxjx sailxjx merged commit 100b70a into main Mar 24, 2022
@sailxjx sailxjx deleted the dev-k8s branch March 24, 2022 02:37
sailxjx added a commit that referenced this pull request Mar 24, 2022
* Add k8s parser

* Support json file

* Style
puyuan1996 pushed a commit to puyuan1996/DI-engine that referenced this pull request Apr 18, 2022
* Add k8s parser

* Support json file

* Style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants