Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(zzh): log videos to tensorboard #320

Merged
merged 11 commits into from
May 20, 2022
Merged

feature(zzh): log videos to tensorboard #320

merged 11 commits into from
May 20, 2022

Conversation

ZHZisZZ
Copy link
Collaborator

@ZHZisZZ ZHZisZZ commented May 14, 2022

Description

Support periodic videos logging in tensoboard when InteractionSerialEvaluator is used with BaseEnvManager, SyncSubprocessEnvManager, AsyncSubprocessEnvManager.

tensorboard screenshot
qbert gif
The worst, median, best evaluation episodes are shown from left to right.

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@PaParaZz1 PaParaZz1 requested a review from Will-Nie May 16, 2022 06:42
@PaParaZz1 PaParaZz1 added the enhancement New feature or request label May 16, 2022
@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #320 (e0b1ad8) into main (fa06b1b) will increase coverage by 0.60%.
The diff coverage is 86.32%.

@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
+ Coverage   86.25%   86.85%   +0.60%     
==========================================
  Files         484      499      +15     
  Lines       36946    38094    +1148     
==========================================
+ Hits        31867    33087    +1220     
+ Misses       5079     5007      -72     
Flag Coverage Δ
unittests 86.85% <86.32%> (+0.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/config/tests/test_config_formatted.py 100.00% <ø> (ø)
ding/data/buffer/__init__.py 100.00% <ø> (ø)
ding/entry/main.py 0.00% <0.00%> (ø)
ding/policy/r2d2.py 89.87% <ø> (-0.07%) ⬇️
ding/torch_utils/__init__.py 100.00% <ø> (ø)
ding/utils/data/dataset.py 69.49% <ø> (+0.32%) ⬆️
ding/worker/__init__.py 100.00% <ø> (ø)
ding/worker/collector/base_serial_evaluator.py 57.89% <11.53%> (-17.47%) ⬇️
ding/torch_utils/data_helper.py 81.30% <27.27%> (-3.01%) ⬇️
ding/utils/render_helper.py 29.41% <29.41%> (ø)
... and 89 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bf0b49...e0b1ad8. Read the comment docs.

@ZHZisZZ ZHZisZZ changed the title WIP: feature(zzh): log videos to tensorboard feature(zzh): log videos to tensorboard May 17, 2022
ding/utils/render_helper.py Outdated Show resolved Hide resolved
ding/utils/render_helper.py Outdated Show resolved Hide resolved
ding/utils/render_helper.py Outdated Show resolved Hide resolved
ding/utils/render_helper.py Show resolved Hide resolved
ding/utils/render_helper.py Outdated Show resolved Hide resolved
ding/envs/env_manager/base_env_manager.py Outdated Show resolved Hide resolved
ding/worker/collector/base_serial_evaluator.py Outdated Show resolved Hide resolved
ding/worker/collector/base_serial_evaluator.py Outdated Show resolved Hide resolved
ding/worker/collector/base_serial_evaluator.py Outdated Show resolved Hide resolved
ding/utils/render_helper.py Outdated Show resolved Hide resolved
ding/utils/render_helper.py Show resolved Hide resolved
ding/worker/collector/base_serial_evaluator.py Outdated Show resolved Hide resolved
Typing lint to avoid circular import
@PaParaZz1 PaParaZz1 merged commit 3bf01a9 into opendilab:main May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants