Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mahuangxu): data collection errors caused by shallow copies #475

Merged
merged 3 commits into from
Sep 14, 2022

Conversation

PaParaZz1
Copy link
Member

Description

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

mahuangxu and others added 2 commits September 8, 2022 14:05
* Data collection errors caused by shallow copies

_def collect_ in sample_serial_collector.py seems wrong cause shallow copies of variable "self._traj_buffer" and "obs".

* Data collection errors caused by shallow copies

_def collect_ in sample_serial_collector.py seems wrong cause shallow copies of variable "self._traj_buffer" and "obs".
After modifying the bug of _def collect_ in sample_serial_collector.py, it can be simplified here.
@PaParaZz1 PaParaZz1 added bug Something isn't working enhancement New feature or request labels Sep 8, 2022
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #475 (b7ea079) into main (225247a) will decrease coverage by 0.13%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main     #475      +/-   ##
==========================================
- Coverage   85.75%   85.62%   -0.14%     
==========================================
  Files         537      537              
  Lines       42992    42997       +5     
==========================================
- Hits        36868    36815      -53     
- Misses       6124     6182      +58     
Flag Coverage Δ
unittests 85.62% <87.50%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/worker/collector/base_serial_collector.py 90.12% <80.00%> (-0.79%) ⬇️
ding/worker/collector/sample_serial_collector.py 91.97% <100.00%> (+0.04%) ⬆️
ding/framework/message_queue/tests/test_redis.py 26.92% <0.00%> (-73.08%) ⬇️
ding/framework/message_queue/redis.py 32.07% <0.00%> (-52.84%) ⬇️
ding/framework/tests/test_parallel.py 92.52% <0.00%> (-4.68%) ⬇️
ding/framework/event_loop.py 92.98% <0.00%> (-3.51%) ⬇️
...worker/replay_buffer/tests/test_advanced_buffer.py 97.83% <0.00%> (-0.44%) ⬇️
ding/envs/env_manager/subprocess_env_manager.py 77.36% <0.00%> (-0.40%) ⬇️
ding/worker/learner/tests/test_base_learner.py 92.13% <0.00%> (+1.12%) ⬆️
ding/utils/data/dataloader.py 47.15% <0.00%> (+2.59%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PaParaZz1 PaParaZz1 merged commit 21e63fc into main Sep 14, 2022
@PaParaZz1 PaParaZz1 deleted the dev-fix-shallow-copy branch September 14, 2022 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants