Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cpwan): fix the type conversion in ding_env_wrapper #483

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

cpwan
Copy link
Contributor

@cpwan cpwan commented Sep 16, 2022

Description

Related Issue

#482

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #483 (d07a341) into main (fbe02b4) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #483      +/-   ##
==========================================
- Coverage   85.67%   85.58%   -0.09%     
==========================================
  Files         539      539              
  Lines       43149    43149              
==========================================
- Hits        36968    36930      -38     
- Misses       6181     6219      +38     
Flag Coverage Δ
unittests 85.58% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/envs/env/ding_env_wrapper.py 90.90% <100.00%> (ø)
ding/framework/message_queue/tests/test_nng.py 42.30% <0.00%> (-57.70%) ⬇️
ding/framework/message_queue/redis.py 32.07% <0.00%> (-45.29%) ⬇️
ding/framework/message_queue/tests/test_redis.py 26.92% <0.00%> (-34.62%) ⬇️
ding/torch_utils/data_helper.py 82.24% <0.00%> (+0.46%) ⬆️
ding/envs/env_manager/subprocess_env_manager.py 77.36% <0.00%> (+0.78%) ⬆️
ding/utils/data/dataloader.py 47.15% <0.00%> (+1.03%) ⬆️
ding/worker/collector/marine_parallel_collector.py 91.24% <0.00%> (+1.38%) ⬆️
ding/worker/learner/comm/flask_fs_learner.py 93.12% <0.00%> (+3.12%) ⬆️
ding/framework/tests/test_parallel.py 96.26% <0.00%> (+3.73%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PaParaZz1 PaParaZz1 merged commit 8ce8808 into opendilab:main Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants