Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(nyz): IGM ding support #486

Merged
merged 6 commits into from
Sep 21, 2022
Merged

feature(nyz): IGM ding support #486

merged 6 commits into from
Sep 21, 2022

Conversation

PaParaZz1
Copy link
Member

Description

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@PaParaZz1 PaParaZz1 added the enhancement New feature or request label Sep 17, 2022
@codecov
Copy link

codecov bot commented Sep 18, 2022

Codecov Report

Merging #486 (8f65082) into main (9e2dee3) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #486      +/-   ##
==========================================
+ Coverage   85.67%   85.76%   +0.08%     
==========================================
  Files         539      537       -2     
  Lines       43148    43111      -37     
==========================================
+ Hits        36967    36972       +5     
+ Misses       6181     6139      -42     
Flag Coverage Δ
unittests 85.76% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/config/config.py 83.84% <100.00%> (+0.05%) ⬆️
ding/config/tests/test_config_formatted.py 100.00% <100.00%> (ø)
ding/envs/env_manager/subprocess_env_manager.py 77.36% <0.00%> (-0.20%) ⬇️
ding/torch_utils/data_helper.py 82.24% <0.00%> (+0.46%) ⬆️
ding/utils/data/dataloader.py 47.15% <0.00%> (+0.51%) ⬆️
ding/worker/learner/tests/test_base_learner.py 92.13% <0.00%> (+1.12%) ⬆️
ding/worker/collector/marine_parallel_collector.py 91.24% <0.00%> (+1.38%) ⬆️
ding/policy/a2c.py 94.21% <0.00%> (+3.10%) ⬆️
ding/worker/learner/comm/flask_fs_learner.py 91.87% <0.00%> (+3.12%) ⬆️
ding/framework/message_queue/redis.py 84.90% <0.00%> (+7.54%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PaParaZz1 PaParaZz1 marked this pull request as ready for review September 21, 2022 15:52
@PaParaZz1 PaParaZz1 merged commit 62b31d6 into main Sep 21, 2022
@PaParaZz1 PaParaZz1 deleted the dev-igm branch September 21, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant