Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish(pu): add save_replay_gif option in lunarlander_env, add mujoco_disc_env #506

Merged
merged 5 commits into from
Oct 10, 2022

Conversation

puyuan1996
Copy link
Collaborator

Description

add save_replay_gif option in lunarlander_env, add mujoco_disc_env

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@puyuan1996 puyuan1996 added the env Questions about RL environment label Oct 8, 2022
@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Merging #506 (32136b3) into main (6c823c5) will decrease coverage by 0.31%.
The diff coverage is 18.18%.

❗ Current head 32136b3 differs from pull request most recent head f8425c8. Consider uploading reports for the commit f8425c8 to get more accurate results

@@            Coverage Diff             @@
##             main     #506      +/-   ##
==========================================
- Coverage   85.49%   85.17%   -0.32%     
==========================================
  Files         528      528              
  Lines       43091    42607     -484     
==========================================
- Hits        36841    36291     -550     
- Misses       6250     6316      +66     
Flag Coverage Δ
unittests 85.17% <18.18%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/envs/common/__init__.py 100.00% <ø> (ø)
ding/envs/common/common_function.py 84.53% <18.18%> (-8.57%) ⬇️
ding/framework/message_queue/tests/test_nng.py 40.00% <0.00%> (-33.08%) ⬇️
ding/model/template/atoc.py 86.31% <0.00%> (-8.95%) ⬇️
ding/worker/learner/comm/flask_fs_learner.py 83.12% <0.00%> (-7.50%) ⬇️
ding/entry/tests/test_parallel_entry.py 45.45% <0.00%> (-4.55%) ⬇️
ding/interaction/tests/interaction/test_errors.py 96.29% <0.00%> (-3.71%) ⬇️
ding/utils/data/dataloader.py 44.55% <0.00%> (-2.60%) ⬇️
ding/world_model/model/tests/test_ensemble.py 71.42% <0.00%> (-2.49%) ⬇️
...envs/env_manager/tests/test_envpool_env_manager.py 36.00% <0.00%> (-2.47%) ⬇️
... and 198 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

dizoo/box2d/lunarlander/envs/lunarlander_env.py Outdated Show resolved Hide resolved
dizoo/box2d/lunarlander/envs/lunarlander_env.py Outdated Show resolved Hide resolved
dizoo/box2d/lunarlander/envs/lunarlander_env.py Outdated Show resolved Hide resolved
dizoo/mujoco/envs/mujoco_disc_env.py Outdated Show resolved Hide resolved
dizoo/mujoco/envs/mujoco_disc_env.py Show resolved Hide resolved
dizoo/mujoco/envs/mujoco_disc_env.py Outdated Show resolved Hide resolved
dizoo/mujoco/envs/mujoco_disc_env.py Outdated Show resolved Hide resolved
dizoo/mujoco/envs/mujoco_disc_env.py Outdated Show resolved Hide resolved
dizoo/mujoco/envs/mujoco_disc_env.py Outdated Show resolved Hide resolved
ding/envs/common/common_function.py Outdated Show resolved Hide resolved
ding/envs/common/common_function.py Show resolved Hide resolved
@PaParaZz1 PaParaZz1 merged commit 446696d into opendilab:main Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
env Questions about RL environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants