Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(pu): add some features in MLP and ResBlock #511

Merged
merged 6 commits into from
Oct 13, 2022

Conversation

puyuan1996
Copy link
Collaborator

@puyuan1996 puyuan1996 commented Oct 11, 2022

Description

add output_activation, output_norm_type, last_linear_layer_init_zero option for MLP, add bias option and downsample block in ResBlock

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@puyuan1996 puyuan1996 added the enhancement New feature or request label Oct 11, 2022
@puyuan1996 puyuan1996 changed the title feature(pu): add output_activation, output_norm_type, last_linear_layer_init_zero option for MLP feature(pu): add some features in MLP and ResBlock Oct 12, 2022
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #511 (210418d) into main (874e923) will increase coverage by 0.12%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##             main     #511      +/-   ##
==========================================
+ Coverage   85.29%   85.41%   +0.12%     
==========================================
  Files         528      526       -2     
  Lines       43223    43144      -79     
==========================================
- Hits        36866    36852      -14     
+ Misses       6357     6292      -65     
Flag Coverage Δ
unittests 85.41% <93.75%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/torch_utils/network/nn_module.py 94.97% <85.71%> (-0.92%) ⬇️
ding/torch_utils/network/res_block.py 100.00% <100.00%> (ø)
ding/torch_utils/network/tests/test_nn_module.py 100.00% <100.00%> (ø)
ding/torch_utils/network/tests/test_res_block.py 100.00% <100.00%> (ø)
ding/framework/message_queue/tests/test_nng.py 42.30% <0.00%> (-30.77%) ⬇️
ding/worker/learner/comm/flask_fs_learner.py 91.25% <0.00%> (+0.62%) ⬆️
ding/envs/env_manager/subprocess_env_manager.py 77.36% <0.00%> (+0.78%) ⬆️
ding/worker/collector/marine_parallel_collector.py 91.24% <0.00%> (+1.38%) ⬆️
ding/framework/event_loop.py 96.49% <0.00%> (+3.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PaParaZz1 PaParaZz1 merged commit 1531a55 into opendilab:main Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants