feature(whl): add PC algorithm #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #514 +/- ##
==========================================
- Coverage 83.60% 83.28% -0.32%
==========================================
Files 564 566 +2
Lines 46237 46600 +363
==========================================
+ Hits 38658 38813 +155
- Misses 7579 7787 +208
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
PaParaZz1
reviewed
Oct 14, 2022
karroyan
reviewed
Oct 18, 2022
added 2 commits
October 19, 2022 12:06
PaParaZz1
requested changes
Mar 6, 2023
PaParaZz1
requested changes
Mar 7, 2023
ding/entry/serial_entry_pc.py
Outdated
|
|
||
|
|
||
| # BFS algorithm | ||
| def get_vi_sequence(env, observation): |
There was a problem hiding this comment.
move this function to ding/utils
ding/entry/serial_entry_pc.py
Outdated
|
|
||
| train_dataset = DataLoader(train_data, batch_size=batch_size, shuffle=True) | ||
| test_dataset = DataLoader(test_data, batch_size=batch_size, shuffle=True) | ||
| return train_dataset, test_dataset |
There was a problem hiding this comment.
move the code related to dataset to ding.utils.data.dataset.py
added 2 commits
March 8, 2023 10:48
PaParaZz1
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
TODO
Check List