Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish(zjow): rename 'eval reward' -> 'episode return' #536

Merged
merged 13 commits into from
Dec 8, 2022

Conversation

zjowowen
Copy link
Collaborator

@zjowowen zjowowen commented Nov 3, 2022

fix typo 'eval reward' -> 'episode return'
fix typo 'eval_reward' -> 'episode_return'
fix typo 'EvalReward' -> 'EpisodeReturn'
fix typo 'final eval reward' -> 'eval episode return'
fix typo 'final_eval_reward' -> 'eval_episode_return'
fix typo 'FinalEvalReward' -> 'EvalEpisodeReturn'

@zjowowen zjowowen added the typo Fix typo label Nov 3, 2022
@zjowowen zjowowen self-assigned this Nov 3, 2022
@PaParaZz1 PaParaZz1 changed the title typo(zjow): fix typo 'eval reward' -> 'episode return' polish(zjow): rename 'eval reward' -> 'episode return' Nov 3, 2022
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #536 (a6a6766) into main (01b1a8b) will decrease coverage by 0.06%.
The diff coverage is 71.08%.

@@            Coverage Diff             @@
##             main     #536      +/-   ##
==========================================
- Coverage   85.37%   85.31%   -0.07%     
==========================================
  Files         532      532              
  Lines       43943    43869      -74     
==========================================
- Hits        37518    37427      -91     
- Misses       6425     6442      +17     
Flag Coverage Δ
unittests 85.31% <71.08%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/entry/serial_entry_gail.py 20.21% <0.00%> (+0.21%) ⬆️
ding/envs/env_manager/envpool_env_manager.py 37.80% <0.00%> (+0.45%) ⬆️
ding/framework/middleware/ckpt_handler.py 96.29% <ø> (ø)
...orker/collector/battle_episode_serial_collector.py 14.28% <0.00%> (+0.08%) ⬆️
...worker/collector/battle_sample_serial_collector.py 13.37% <0.00%> (ø)
ding/worker/collector/metric_serial_evaluator.py 84.69% <ø> (ø)
...orker/coordinator/one_vs_one_parallel_commander.py 98.22% <ø> (ø)
ding/worker/coordinator/solo_parallel_commander.py 0.00% <ø> (ø)
ding/worker/learner/base_learner.py 95.79% <ø> (ø)
ding/envs/env/tests/test_ding_env_wrapper.py 72.80% <50.00%> (+0.77%) ⬆️
... and 79 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PaParaZz1 PaParaZz1 added the env Questions about RL environment label Nov 7, 2022
@PaParaZz1 PaParaZz1 merged commit dd2b3a5 into opendilab:main Dec 8, 2022
@zjowowen zjowowen deleted the fix-return branch October 7, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
env Questions about RL environment typo Fix typo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants