Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(nyz): add evaluator more info viz support #538

Merged
merged 4 commits into from
Nov 12, 2022
Merged

Conversation

PaParaZz1
Copy link
Member

@PaParaZz1 PaParaZz1 commented Nov 7, 2022

Description

  • save replay video
  • save content in varaible info returned from env.step
  • save infomation returned from policy.forward

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@PaParaZz1 PaParaZz1 added the enhancement New feature or request label Nov 7, 2022
@PaParaZz1 PaParaZz1 changed the title Dev eval viz feature(nyz): add evaluator more info viz support Nov 7, 2022
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #538 (99e97ee) into main (40c9bca) will increase coverage by 0.00%.
The diff coverage is 29.62%.

❗ Current head 99e97ee differs from pull request most recent head b9a0dae. Consider uploading reports for the commit b9a0dae to get more accurate results

@@           Coverage Diff            @@
##             main     #538    +/-   ##
========================================
  Coverage   85.43%   85.44%            
========================================
  Files         526      526            
  Lines       43304    43513   +209     
========================================
+ Hits        36996    37178   +182     
- Misses       6308     6335    +27     
Flag Coverage Δ
unittests 85.44% <29.62%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/envs/env_manager/subprocess_env_manager.py 76.71% <0.00%> (-0.64%) ⬇️
ding/torch_utils/__init__.py 100.00% <ø> (ø)
ding/framework/middleware/functional/evaluator.py 53.97% <26.15%> (-12.41%) ⬇️
ding/torch_utils/data_helper.py 77.35% <33.33%> (-2.38%) ⬇️
ding/framework/middleware/functional/collector.py 97.10% <100.00%> (+0.04%) ⬆️
ding/framework/message_queue/tests/test_nng.py 73.07% <0.00%> (-26.93%) ⬇️
ding/worker/learner/comm/flask_fs_learner.py 91.25% <0.00%> (-0.63%) ⬇️
ding/framework/parallel.py 84.97% <0.00%> (-0.52%) ⬇️
ding/entry/serial_entry_onpolicy.py 96.29% <0.00%> (+0.55%) ⬆️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

zerlinwang and others added 2 commits November 10, 2022 20:55
* fix(wzl): fix bugs for dict dobs in new pipeline

* fix(wzl): use get_shape0 func in new pipeline

* feature(wzl): add newline for style check
@PaParaZz1 PaParaZz1 merged commit 721e671 into main Nov 12, 2022
@PaParaZz1 PaParaZz1 deleted the dev-eval-viz branch November 12, 2022 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants