feature(zjow): add wandb logger features; fix relative bugs for wandb online logger #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjowowen
added
bug
zjowowen
changed the title
PaParaZz1
requested changes
Feb 22, 2023
Codecov Report
@@ Coverage Diff @@
## main #579 +/- ##
==========================================
- Coverage 83.34% 82.96% -0.39%
==========================================
Files 569 570 +1
Lines 46819 47013 +194
==========================================
- Hits 39022 39004 -18
- Misses 7797 8009 +212
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
zjowowen
commented
Mar 7, 2023
zjowowen
commented
Mar 7, 2023
zjowowen
commented
Mar 7, 2023
zjowowen
commented
Mar 7, 2023
zjowowen
commented
Mar 7, 2023
zjowowen
commented
Mar 7, 2023
PaParaZz1
requested changes
Mar 9, 2023
| @@ -1,6 +1,7 @@ | |||
| from typing import TYPE_CHECKING, Callable, List, Tuple, Any | |||
| from easydict import EasyDict | |||
| from functools import reduce | |||
| import numpy as np | |||
| @@ -257,7 +257,7 @@ def _evaluate(ctx: Union["OnlineRLContext", "OfflineRLContext"]): | |||
| eval_monitor.update_video(env.ready_imgs) | |||
| eval_monitor.update_output(inference_output) | |||
| output = [v for v in inference_output.values()] | |||
| action = [to_ndarray(v['action']) for v in output] # TBD | |||
| action = np.array([to_ndarray(v['action']) for v in output]) # TBD | |||
ding/policy/td3.py
Outdated
|
|
||
| def monitor_vars(self) -> List[str]: | ||
| variables = ["q_value", "target q_value", "loss", "lr", "entropy", "target_q_value", "td_error"] | ||
| return variables |
ding/bonus/td3.py
Outdated
| wandb_url: str | ||
|
|
||
|
|
||
| class TD3: |
PaParaZz1
approved these changes
Mar 16, 2023
PaParaZz1
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add and fix wandb logger features for rendering videos and logging information during training, which is tested in algorithms td3/ddpg/sac.
Fix relative bugs for wandb online logger.
Copy changes to wandb offline logger.