Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(luyd): add collector logging in new pipeline #735

Merged
merged 7 commits into from
Oct 16, 2023

Conversation

AltmanD
Copy link
Collaborator

@AltmanD AltmanD commented Oct 7, 2023

Description

add feature of logging in collector while using new pipeline.

Related Issue

#723

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@AltmanD AltmanD requested a review from PaParaZz1 October 7, 2023 04:18
@AltmanD AltmanD self-assigned this Oct 7, 2023
@PaParaZz1 PaParaZz1 added the enhancement New feature or request label Oct 7, 2023
@@ -98,6 +108,59 @@ def rolloutor(policy: Policy, env: BaseEnvManager, transitions: TransitionList)

env_episode_id = [_ for _ in range(env.env_num)]
current_id = env.env_num
timer = EasyTimer()
last_train_iter = 0
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no tensorboard

env: BaseEnvManager,
transitions: TransitionList,
collect_print_freq=100,
tb_logger=None,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no tensorboard

else:
logger, tb_logger = build_logger(path='./{}/log/{}'.format(exp_name, instance_name), name=instance_name)

def output_log(train_iter: int) -> None:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to outside of function

@AltmanD AltmanD marked this pull request as ready for review October 16, 2023 01:50
policy: Policy,
env: BaseEnvManager,
transitions: TransitionList,
collect_print_freq=100,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typing

@PaParaZz1 PaParaZz1 merged commit 5d5489f into opendilab:main Oct 16, 2023
15 of 18 checks passed
@AltmanD AltmanD deleted the dev-log2new branch October 17, 2023 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants