Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish(pu): polish comments and styles in files within torch_utils/network #745

Merged
merged 13 commits into from
Dec 28, 2023

Conversation

puyuan1996
Copy link
Collaborator

@puyuan1996 puyuan1996 commented Oct 31, 2023

Description

  • polish the comments and code styles in the files located within the ding/torch_utils/network/ directory.

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@puyuan1996 puyuan1996 added the doc Documentation label Oct 31, 2023
ding/torch_utils/network/activation.py Outdated Show resolved Hide resolved
ding/torch_utils/network/activation.py Outdated Show resolved Hide resolved
ding/torch_utils/network/activation.py Outdated Show resolved Hide resolved
ding/torch_utils/network/activation.py Outdated Show resolved Hide resolved
ding/torch_utils/network/activation.py Outdated Show resolved Hide resolved
ding/torch_utils/network/activation.py Outdated Show resolved Hide resolved
ding/torch_utils/network/activation.py Outdated Show resolved Hide resolved
ding/torch_utils/network/gumbel_softmax.py Outdated Show resolved Hide resolved
ding/torch_utils/network/gumbel_softmax.py Outdated Show resolved Hide resolved
ding/torch_utils/network/gtrxl.py Show resolved Hide resolved
ding/torch_utils/network/gtrxl.py Show resolved Hide resolved
ding/torch_utils/network/gtrxl.py Show resolved Hide resolved
ding/torch_utils/network/gtrxl.py Show resolved Hide resolved
ding/torch_utils/network/popart.py Outdated Show resolved Hide resolved
ding/torch_utils/network/popart.py Outdated Show resolved Hide resolved
ding/torch_utils/network/res_block.py Show resolved Hide resolved
ding/torch_utils/network/res_block.py Show resolved Hide resolved
ding/torch_utils/network/res_block.py Outdated Show resolved Hide resolved
ding/torch_utils/network/rnn.py Outdated Show resolved Hide resolved
ding/torch_utils/network/rnn.py Show resolved Hide resolved
ding/torch_utils/network/nn_module.py Outdated Show resolved Hide resolved
ding/torch_utils/network/resnet.py Show resolved Hide resolved
ding/torch_utils/network/soft_argmax.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ac9fa76) 77.10% compared to head (174370d) 77.07%.

❗ Current head 174370d differs from pull request most recent head df2fe3e. Consider uploading reports for the commit df2fe3e to get more accurate results

Files Patch % Lines
ding/torch_utils/network/resnet.py 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #745      +/-   ##
==========================================
- Coverage   77.10%   77.07%   -0.03%     
==========================================
  Files         671      671              
  Lines       53775    53774       -1     
==========================================
- Hits        41461    41448      -13     
- Misses      12314    12326      +12     
Flag Coverage Δ
unittests 77.07% <98.07%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PaParaZz1 PaParaZz1 merged commit beb91d9 into opendilab:main Dec 28, 2023
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants