feature(wrh): add taxi env #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taxi env first commit
PaParaZz1
requested changes
May 29, 2024
dizoo/taxi/envs/taxi_env.py
Outdated
| def __init__(self, cfg: dict) -> None: | ||
|
|
||
| #^ 该部分为初始化定义，需要有的 | ||
| self._cfg = EasyDict( |
There was a problem hiding this comment.
use the implementation like default_config in other previous environment in dizoo
ruiheng123
changed the title
PaParaZz1
changed the title
ruiheng123
changed the title
zjowowen
reviewed
May 30, 2024
dizoo/taxi/envs/taxi_env.py
Outdated
| # Clean up temporary image files | ||
| for temp_image_file in temp_image_files: | ||
| os.remove(temp_image_file) | ||
| print(f"GIF saved as {gif_path}") |
There was a problem hiding this comment.
use log instead of print.
zjowowen
reviewed
May 30, 2024
|
|
||
| @staticmethod | ||
| def frames_to_gif(frames: List[imageio.core.util.Array], gif_path: str, duration: float = 0.1) -> None: | ||
| """ |
There was a problem hiding this comment.
Polish argument list as the format in https://github.com/opendilab/DI-engine/blob/main/ding/model/common/encoder.py.
PaParaZz1
approved these changes
May 30, 2024
PaParaZz1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
TODO
Check List