Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve 3.3.2 #4718

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Resolve 3.3.2 #4718

wants to merge 1 commit into from

Conversation

slubwama
Copy link
Contributor

@slubwama slubwama commented Aug 16, 2024

Description of what I changed

Issue I worked on

Issue: 3.3.2

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@rkorytkowski
Copy link
Member

Have you tested it locally? It is very likely that it won't work if you are not using https to access the web server, which is typical for localhost (development) and also may be for some simple implementations that run in LAN and didn't setup https.

@slubwama
Copy link
Contributor Author

slubwama commented Aug 26, 2024

Have you tested it locally? It is very likely that it won't work if you are not using https to access the web server, which is typical for localhost (development) and also may be for some simple implementations that run in LAN and didn't setup https.

@rkorytkowski I tested in an environment with HTTP and it seemed fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants