Add tests against multiple Nodejs versions #7177
Conversation
* commit 'ccb045b68c5b4d983a90fa125513fc476e4e2387': fix: upgrade @graphql-tools/links from 6.2.4 to 6.2.5 (parse-community#7007) fix: upgrade pg-promise from 10.7.0 to 10.7.1 (parse-community#7009) fix: upgrade jwks-rsa from 1.10.1 to 1.11.0 (parse-community#7008) fix: upgrade graphql from 15.3.0 to 15.4.0 (parse-community#7011) update stale bot (parse-community#6998) fix(beforeSave/afterSave): Return value instead of Parse.Op for nested fields (parse-community#7005) fix(beforeSave): Skip Sanitizing Database results (parse-community#7003) Fix includeAll for querying a Pointer and Pointer array (parse-community#7002) Init (parse-community#6999)
* commit '7f47b0427ea56214d9b0199f0fcfa4af38794e02': Add page localization (parse-community#7128) Improve contribution guide (parse-community#7075) fix: upgrade pg-promise from 10.9.0 to 10.9.1 (parse-community#7170) Add tests against multiple MongoDB versions (parse-community#7161) fix: upgrade mime from 2.4.7 to 2.5.0 (parse-community#7166) fix: upgrade pg-promise from 10.8.7 to 10.9.0 (parse-community#7168) fix: upgrade apollo-server-express from 2.19.1 to 2.19.2 (parse-community#7165) Upgrade @node-rs/bcrypt to latest version (parse-community#7159) Run Prettier after Definitions (parse-community#7164)
Codecov Report
@@ Coverage Diff @@
## master #7177 +/- ##
==========================================
+ Coverage 94.00% 94.02% +0.01%
==========================================
Files 172 172
Lines 12835 12834 -1
==========================================
+ Hits 12066 12067 +1
+ Misses 769 767 -2
Continue to review full report at Codecov.
|
|
What about Node 15? We can start preparing for Node 16 that is coming in April. |
|
I may have misunderstood the status of 15 in the release plan, but I looked again and it seems you are right, we can add 15. It seems to be actively being worked on while in release, it's like a "we are almost done but it's good to use already, we won't add any breaking changes but likely some non-breaking changes" release. We are currently running most tests with Node 10.x by default:
To which version should we bump the default Node version? I'd say it should be the version that most Parse Server deployments currently run on. |
|
@dplewis I did more research and it confirms what you suggested: According to Node.js:
That also implies that the default Node.js version for tests may well be bumped from Node 10 to 14, which is in Active long term support and the most recent version that is recommended for production apps. I will do this in this PR.
|
* added nodejs version check * added changelog entry * fixed MongoDB ignored versions * fixed nodejs test versions * fixed typo * added changelog entry * added node 15 to CI checks * improved log wording * bumped nodejs default to 14 * added Node 15 to compatibility table
|
🎉 This change has been released in version 5.0.0-beta.1 |
|
🎉 This change has been released in version 5.0.0 |
New Pull Request Checklist
Issue Description
Parse Server is not tested against latest Nodejs versions.
Related issue: closes #7169
Approach
Adding CI test script that automatically checks whether
TODOs before merging