Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T16634 docblock reference #16635

Merged
merged 7 commits into from
Aug 13, 2024
Merged

T16634 docblock reference #16635

merged 7 commits into from
Aug 13, 2024

Conversation

niden
Copy link
Sponsor Member

@niden niden commented Aug 13, 2024

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed the @property of Injectable for the DI

Thanks

@niden niden requested a review from Jeckerson August 13, 2024 14:17
@niden niden self-assigned this Aug 13, 2024
@niden niden added bug A bug report status: medium Medium 5.0 The issues we want to solve in the 5.0 release labels Aug 13, 2024
@niden niden merged commit 83677f1 into phalcon:master Aug 13, 2024
50 checks passed
@niden niden deleted the T16634-docblock-reference branch August 13, 2024 15:04
This was referenced Aug 13, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

@apoca apoca apoca approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@niden @Jeckerson @apoca @Arhell