Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @primer/primitives v8 colors with fallbacks #2466

Merged
merged 5 commits into from
Jun 21, 2023
Merged

Conversation

langermank
Copy link
Contributor

What are you trying to accomplish?

Utilizes updated stylelint plugins to upgrade to the new primitive v8 tokens with inline fallbacks.

What approach did you choose and why?

yarn run stylelint:fix and some find/replace

What should reviewers focus on?

Can these changes ship as is?

  • Yes, this PR does not depend on additional changes. 🚢

@langermank langermank requested a review from a team as a code owner June 20, 2023 18:33
@langermank langermank requested a review from simurai June 20, 2023 18:33
@changeset-bot
Copy link

changeset-bot bot commented Jun 20, 2023

🦋 Changeset detected

Latest commit: 5930bac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to Storybook Preview June 20, 2023 18:42 Inactive
@langermank langermank temporarily deployed to github-pages June 20, 2023 18:43 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview June 20, 2023 18:44 Inactive
@langermank langermank temporarily deployed to github-pages June 20, 2023 18:52 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview June 20, 2023 18:52 Inactive
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@langermank langermank merged commit 9204701 into main Jun 21, 2023
12 checks passed
@langermank langermank deleted the primitives-v8 branch June 21, 2023 20:56
@primer-css primer-css mentioned this pull request Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants