Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report needless disables in CI, bump stylelint, tidy scripts #912

Merged
merged 11 commits into from
Sep 25, 2019

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Sep 25, 2019

This adds a call to stylelint --report-needless-disables to our lint test in Actions. I also bumped us to stylelint@^10.1.0 order to get the better output that @muan added in stylelint/stylelint#4071, and bumped a couple of other dev dependency versions while I was in there.

I've also removed the --unsafe-perm flags from calls to npm in our Actions workflows, since those were only necessary when we had pre- and post- scripts. (We seem to have gotten rid of all of those — maybe both after migrating from Next to Gatsby, then to Doctocat?)

TODO

  • get this running and failing CI (see: this failure)
  • fix the needless disables
  • get it passing again

@vercel
Copy link

vercel bot commented Sep 25, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://primer-css-git-needless-disables.primer.now.sh

@shawnbot shawnbot marked this pull request as ready for review September 25, 2019 22:16
@shawnbot shawnbot changed the base branch from master to release-13.0.2 September 25, 2019 22:16
@simurai simurai mentioned this pull request Sep 25, 2019
10 tasks
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, especially the remove needless disables script

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants