Skip to content

Fix build.

Fix build. #29

Triggered via push October 25, 2023 07:55
Status Success
Total duration 3m 5s
Artifacts

check.yml

on: push
Matrix: tests
Fit to window
Zoom out
Zoom in

Annotations

17 warnings
missing documentation for a function: src/path.rs#L82
warning: missing documentation for a function --> src/path.rs:82:5 | 82 | / pub fn to_string(path: &mut PathBuf) -> String { 83 | | path.to_str().unwrap_or_default().into() 84 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items
missing documentation for a function: src/path.rs#L77
warning: missing documentation for a function --> src/path.rs:77:5 | 77 | / pub fn append(path1: &mut PathBuf, path2: PathBuf) { 78 | | path1.push(path2); 79 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items
missing documentation for a function: src/path.rs#L72
warning: missing documentation for a function --> src/path.rs:72:5 | 72 | / pub fn add_string(path: &mut PathBuf, str: &str) -> PathBuf { 73 | | path.join(Path::new(str)) 74 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items
missing documentation for a function: src/path.rs#L67
warning: missing documentation for a function --> src/path.rs:67:5 | 67 | / pub fn add(path1: &mut PathBuf, path2: PathBuf) -> PathBuf { 68 | | path1.join(path2) 69 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items
missing documentation for a module: src/lib.rs#L18
warning: missing documentation for a module --> src/lib.rs:18:1 | 18 | pub(crate) mod path; | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items
the function `borrow_mut` doesn't need a mutable reference: src/file.rs#L272
warning: the function `borrow_mut` doesn't need a mutable reference --> src/file.rs:272:30 | 272 | match borrow_mut(&mut file).write(blob) { | ^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
the function `borrow_mut` doesn't need a mutable reference: src/file.rs#L260
warning: the function `borrow_mut` doesn't need a mutable reference --> src/file.rs:260:30 | 260 | match borrow_mut(&mut file).read(blob) { | ^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default
missing documentation for a type alias: src/file.rs#L26
warning: missing documentation for a type alias --> src/file.rs:26:5 | 26 | pub type SharedFile = Shared<Locked<File>>; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items
missing documentation for a function: src/file.rs#L16
warning: missing documentation for a function --> src/file.rs:16:1 | 16 | / fn borrow_mut(file: &Shared<Locked<File>>) -> impl DerefMut<Target = File> + '_ { 17 | | #[cfg(not(feature = "sync"))] 18 | | return file.borrow_mut(); 19 | | 20 | | #[cfg(feature = "sync")] 21 | | return file.write().unwrap(); 22 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items
missing documentation for a function: src/file.rs#L10
warning: missing documentation for a function --> src/file.rs:10:1 | 10 | / fn convert_to_int(val: impl TryInto<rhai::INT>) -> Result<rhai::INT, Box<EvalAltResult>> { 11 | | val.try_into() 12 | | .map_err(|_| "Error converting number {new_pos} to rhai number type".into()) 13 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items
missing documentation for a module: src/lib.rs#L17
warning: missing documentation for a module --> src/lib.rs:17:1 | 17 | pub(crate) mod file; | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items
missing documentation for a module: src/lib.rs#L16
warning: missing documentation for a module --> src/lib.rs:16:1 | 16 | pub(crate) mod dir; | ^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items note: the lint level is defined here --> src/lib.rs:2:9 | 2 | #![warn(clippy::missing_docs_in_private_items)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
the function `borrow_mut` doesn't need a mutable reference: src/file.rs#L272
warning: the function `borrow_mut` doesn't need a mutable reference --> src/file.rs:272:30 | 272 | match borrow_mut(&mut file).write(blob) { | ^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
the function `borrow_mut` doesn't need a mutable reference: src/file.rs#L260
warning: the function `borrow_mut` doesn't need a mutable reference --> src/file.rs:260:30 | 260 | match borrow_mut(&mut file).read(blob) { | ^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default
this `if` statement can be collapsed: build.rs#L169
warning: this `if` statement can be collapsed --> build.rs:169:17 | 169 | / if idx != 0 && idx < function_list.len() - 1 { 170 | | if name == function_list[idx - 1].name && name != function_list[idx + 1].name { 171 | | indented = false; 172 | | } 173 | | } | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 169 ~ if idx != 0 && idx < function_list.len() - 1 && name == function_list[idx - 1].name && name != function_list[idx + 1].name { 170 + indented = false; 171 + } |
this `if` statement can be collapsed: build.rs#L151
warning: this `if` statement can be collapsed --> build.rs:151:17 | 151 | / if idx < function_list.len() - 1 { 152 | | if name == function_list[idx + 1].name && !indented { 153 | | writeln!(writer, "## {prefix}`{}`", name.to_owned()) 154 | | .expect("Cannot write to {doc_file}"); 155 | | indented = true; 156 | | } 157 | | } | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if = note: `#[warn(clippy::collapsible_if)]` on by default help: collapse nested if block | 151 ~ if idx < function_list.len() - 1 && name == function_list[idx + 1].name && !indented { 152 + writeln!(writer, "## {prefix}`{}`", name.to_owned()) 153 + .expect("Cannot write to {doc_file}"); 154 + indented = true; 155 + } |
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/