Stabilize RUSTC_WORKSPACE_WRAPPER #8976

ebroto · 2020-12-13T23:00:05Z

Stabilizing this environment variable would allow Clippy to fix a long-standing usability problem, clippy#4612.

It's also the last step towards stabilizing the --fix command-line argument in Clippy, that allows applying suggestions automatically when the lint supports it.

Closes #8143

r? @ehuss

ehuss · 2020-12-14T16:29:05Z

Thanks!

@rust-lang/cargo Proposal to stabilize a new env var in Cargo. See this PR and #8143 for details.

@rfcbot fcp merge

rfcbot · 2020-12-14T16:29:06Z

Team member @ehuss has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

Eh2406 · 2020-12-14T16:54:09Z

There seem to be a lot of open questions on #8143, I'd like to see answers or explanations of why there no longer relevant.

ehuss · 2020-12-14T18:27:57Z

Of course!

Is this the right design?

I cannot think of anything particularly better.

This doesn't help with wrapping only specific crates

This has been resolved by adding CARGO_PRIMARY_PACKAGE in #8758. Wrappers can inspect that environment variable to determine if this is a root package, or some other dependency in the workspace. rust-lang/rust-clippy#6188 added --no-deps for clippy to make the choice explicit. This also resolved by concern about cargo clippy --fix in a large workspace.

RUSTC_WORKSPACE_WRAPPER doesn't currently work with sccache

I just tried, and it seems to work now. I'm not too familiar with sccache, and it has always been kinda flaky for me, so I'm not really sure if it can be used reliably, but it seems ok now.

Some tools may want to use arguments with the wrapper.

Cargo doesn't support passing arguments in any of the other wrapper env vars, so I'm not too concerned here. It would be difficult because otherwise they wouldn't allow spaces in filenames (a generally unsolved problem in Cargo). I think if that seems important, one option is to add some environment variable to detect when in wrapper mode. Another option would be to do something like TOML syntax (similar to -Zadvanced-env) to allow passing arguments with spaces.

rfcbot · 2020-12-14T19:27:00Z

🔔 This is now entering its final comment period, as per the review above. 🔔

ehuss · 2020-12-21T19:37:26Z

Thanks @ebroto!

@bors r+

bors · 2020-12-21T19:37:27Z

📌 Commit f838a00 has been approved by ehuss

bors · 2020-12-21T19:37:36Z

⌛ Testing commit f838a00 with merge e10b791...

bors · 2020-12-21T20:10:07Z

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing e10b791 to master...

Update cargo 10 commits in a3c2627fbc2f5391c65ba45ab53b81bf71fa323c..75d5d8cffe3464631f82dcd3c470b78dc1dda8bb 2020-12-14 17:21:26 +0000 to 2020-12-22 18:10:56 +0000 - Update git2 (rust-lang/cargo#9009) - Stabilize RUSTC_WORKSPACE_WRAPPER (rust-lang/cargo#8976) - Make cargo metadata and tree respect target (rust-lang/cargo#8987) - Update git2 (rust-lang/cargo#8998) - Revert rust-lang/cargo#8954 - changing rustdoc's cwd (rust-lang/cargo#8996) - With debug HTTP mode log curl's version (rust-lang/cargo#8991) - Reject ambiguous git dependency declaration. (rust-lang/cargo#8984) - Fix tests not working with a different CARGO_TARGET_DIR. (rust-lang/cargo#8982) - Add version to credential dependencies. (rust-lang/cargo#8983) - Clarify FAQ entry wording about lockfiles (rust-lang/cargo#8978)

Stabilize workspace wrapper. This fixes it so that `cargo clippy` doesn't share the same cache artifacts as `cargo check`. The Cargo side was stabilized a while ago (rust-lang/cargo#8976), so this should be ready to go. I'm not aware of any blockers or concerns. Closes #4612 --- changelog: `cargo clippy` no longer shares the same build cache as `cargo check`.

Pkgsrc changes: * Adjust patches, re-compute line offsets, fix capitalization. * Remove i686/FreeBSD support, no longer provided upstream. * Bump bootstraps to 1.49.0. * Change USE_TOOLS from bsdtar to gtar. * Reduce diffs to pkgsrc-wip package patches. * Allow rust.BUILD_TARGET to override automatic choice of target. * Add an i586/NetBSD (pentium) bootstrap variant (needs testing), not yet added as bootstrap since 1.49 doesn't have that variant. Upstream changes: Version 1.50.0 (2021-02-11) ============================ Language ----------------------- - [You can now use `const` values for `x` in `[x; N]` array expressions.][79270] This has been technically possible since 1.38.0, as it was unintentionally stabilized. - [Assignments to `ManuallyDrop<T>` union fields are now considered safe.][78068] Compiler ----------------------- - [Added tier 3\* support for the `armv5te-unknown-linux-uclibceabi` target.][78142] - [Added tier 3 support for the `aarch64-apple-ios-macabi` target.][77484] - [The `x86_64-unknown-freebsd` is now built with the full toolset.][79484] \* Refer to Rust's [platform support page][forge-platform-support] for more information on Rust's tiered platform support. Libraries ----------------------- - [`proc_macro::Punct` now implements `PartialEq<char>`.][78636] - [`ops::{Index, IndexMut}` are now implemented for fixed sized arrays of any length.][74989] - [On Unix platforms, the `std::fs::File` type now has a "niche" of `-1`.][74699] This value cannot be a valid file descriptor, and now means `Option<File>` takes up the same amount of space as `File`. Stabilized APIs --------------- - [`bool::then`] - [`btree_map::Entry::or_insert_with_key`] - [`f32::clamp`] - [`f64::clamp`] - [`hash_map::Entry::or_insert_with_key`] - [`Ord::clamp`] - [`RefCell::take`] - [`slice::fill`] - [`UnsafeCell::get_mut`] The following previously stable methods are now `const`. - [`IpAddr::is_ipv4`] - [`IpAddr::is_ipv6`] - [`Layout::size`] - [`Layout::align`] - [`Layout::from_size_align`] - `pow` for all integer types. - `checked_pow` for all integer types. - `saturating_pow` for all integer types. - `wrapping_pow` for all integer types. - `next_power_of_two` for all unsigned integer types. - `checked_power_of_two` for all unsigned integer types. Cargo ----------------------- - [Added the `[build.rustc-workspace-wrapper]` option.][cargo/8976] This option sets a wrapper to execute instead of `rustc`, for workspace members only. - [`cargo:rerun-if-changed` will now, if provided a directory, scan the entire contents of that directory for changes.][cargo/8973] - [Added the `--workspace` flag to the `cargo update` command.][cargo/8725] Misc ---- - [The search results tab and the help button are focusable with keyboard in rustdoc.][79896] - [Running tests will now print the total time taken to execute.][75752] Compatibility Notes ------------------- - [The `compare_and_swap` method on atomics has been deprecated.][79261] It's recommended to use the `compare_exchange` and `compare_exchange_weak` methods instead. - [Changes in how `TokenStream`s are checked have fixed some cases where you could write unhygenic `macro_rules!` macros.][79472] - [`#![test]` as an inner attribute is now considered unstable like other inner macro attributes, and reports an error by default through the `soft_unstable` lint.][79003] - [Overriding a `forbid` lint at the same level that it was set is now a hard error.][78864] - [Dropped support for all cloudabi targets.][78439] - [You can no longer intercept `panic!` calls by supplying your own macro.][78343] It's recommended to use the `#[panic_handler]` attribute to provide your own implementation. - [Semi-colons after item statements (e.g. `struct Foo {};`) now produce a warning.][78296] [74989]: rust-lang/rust#74989 [79261]: rust-lang/rust#79261 [79896]: rust-lang/rust#79896 [79484]: rust-lang/rust#79484 [79472]: rust-lang/rust#79472 [79270]: rust-lang/rust#79270 [79003]: rust-lang/rust#79003 [78864]: rust-lang/rust#78864 [78636]: rust-lang/rust#78636 [78439]: rust-lang/rust#78439 [78343]: rust-lang/rust#78343 [78296]: rust-lang/rust#78296 [78068]: rust-lang/rust#78068 [75752]: rust-lang/rust#75752 [74699]: rust-lang/rust#74699 [78142]: rust-lang/rust#78142 [77484]: rust-lang/rust#77484 [cargo/8976]: rust-lang/cargo#8976 [cargo/8973]: rust-lang/cargo#8973 [cargo/8725]: rust-lang/cargo#8725 [`IpAddr::is_ipv4`]: https://doc.rust-lang.org/stable/std/net/enum.IpAddr.html#method.is_ipv4 [`IpAddr::is_ipv6`]: https://doc.rust-lang.org/stable/std/net/enum.IpAddr.html#method.is_ipv6 [`Layout::align`]: https://doc.rust-lang.org/stable/std/alloc/struct.Layout.html#method.align [`Layout::from_size_align`]: https://doc.rust-lang.org/stable/std/alloc/struct.Layout.html#method.from_size_align [`Layout::size`]: https://doc.rust-lang.org/stable/std/alloc/struct.Layout.html#method.size [`Ord::clamp`]: https://doc.rust-lang.org/stable/std/cmp/trait.Ord.html#method.clamp [`RefCell::take`]: https://doc.rust-lang.org/stable/std/cell/struct.RefCell.html#method.take [`UnsafeCell::get_mut`]: https://doc.rust-lang.org/stable/std/cell/struct.UnsafeCell.html#method.get_mut [`bool::then`]: https://doc.rust-lang.org/stable/std/primitive.bool.html#method.then [`btree_map::Entry::or_insert_with_key`]: https://doc.rust-lang.org/stable/std/collections/btree_map/enum.Entry.html#method.or_insert_with_key [`f32::clamp`]: https://doc.rust-lang.org/stable/std/primitive.f32.html#method.clamp [`f64::clamp`]: https://doc.rust-lang.org/stable/std/primitive.f64.html#method.clamp [`hash_map::Entry::or_insert_with_key`]: https://doc.rust-lang.org/stable/std/collections/hash_map/enum.Entry.html#method.or_insert_with_key [`slice::fill`]: https://doc.rust-lang.org/stable/std/primitive.slice.html#method.fill

Stabilize RUSTC_WORKSPACE_WRAPPER

f838a00

rust-highfive assigned ehuss Dec 13, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 13, 2020

ebroto mentioned this pull request Dec 13, 2020

cargo fix cmd no longer works rust-lang/rust-clippy#5358

Closed

ehuss added the T-cargo Team: Cargo label Dec 14, 2020

rfcbot added proposed-final-comment-period An FCP proposal has started, but not yet signed off. disposition-merge FCP with intent to merge labels Dec 14, 2020

rfcbot added the final-comment-period FCP — a period for last comments before action is taken label Dec 14, 2020

rfcbot removed the proposed-final-comment-period An FCP proposal has started, but not yet signed off. label Dec 14, 2020

Eh2406 mentioned this pull request Dec 21, 2020

cargo clippy and cargo check don't recognize source code changes without --release flag #9004

Closed

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 21, 2020

bors merged commit e10b791 into rust-lang:master Dec 21, 2020

ebroto deleted the rustc_workspace_wrapper branch December 21, 2020 22:26

ehuss mentioned this pull request Dec 23, 2020

Update cargo rust-lang/rust#80322

Merged

rfcbot added finished-final-comment-period FCP complete to-announce and removed final-comment-period FCP — a period for last comments before action is taken labels Dec 24, 2020

ehuss mentioned this pull request Feb 6, 2021

Stabilize workspace wrapper. rust-lang/rust-clippy#6687

Merged

ehuss added this to the 1.50.0 milestone Feb 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stabilize RUSTC_WORKSPACE_WRAPPER #8976

Stabilize RUSTC_WORKSPACE_WRAPPER #8976

ebroto commented Dec 13, 2020 •

edited

Loading

ehuss commented Dec 14, 2020

rfcbot commented Dec 14, 2020 •

edited by Eh2406

Loading

Eh2406 commented Dec 14, 2020

ehuss commented Dec 14, 2020

rfcbot commented Dec 14, 2020

ehuss commented Dec 21, 2020

bors commented Dec 21, 2020

bors commented Dec 21, 2020

bors commented Dec 21, 2020

Stabilize RUSTC_WORKSPACE_WRAPPER #8976

Stabilize RUSTC_WORKSPACE_WRAPPER #8976

Conversation

ebroto commented Dec 13, 2020 • edited Loading

ehuss commented Dec 14, 2020

rfcbot commented Dec 14, 2020 • edited by Eh2406 Loading

Eh2406 commented Dec 14, 2020

ehuss commented Dec 14, 2020

rfcbot commented Dec 14, 2020

ehuss commented Dec 21, 2020

bors commented Dec 21, 2020

bors commented Dec 21, 2020

bors commented Dec 21, 2020

ebroto commented Dec 13, 2020 •

edited

Loading

rfcbot commented Dec 14, 2020 •

edited by Eh2406

Loading